On Wed, 4 Jan 2012, Ronald S. Bultje wrote:

On Wed, Jan 4, 2012 at 5:21 AM, Martin Storsjö <mar...@martin.st> wrote:
From: Jean First <jeanfi...@gmail.com>

This one won't ever be used uninitialized in practice, but
the compiler doesn't realize it.

Signed-off-by: Martin Storsjö <mar...@martin.st>
---
 libavformat/rtsp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Didn't we have av_uninitialized_safe or so for that?

Yes, av_uninit, but I prefer a proper initialization, since the av_uninit declaration would hide the issue if we later change the code so that it suddenly could be used uninitialized. Also, in this case, it really isn't performance critical.

// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to