Diego Biurrun <di...@biurrun.de> writes:

> ---
>  tests/fate/ac3.mak            |   15 ++++++----
>  tests/fate/amrnb.mak          |   19 +++++++-----
>  tests/fate/amrwb.mak          |   23 ++++++++------
>  tests/fate/atrac.mak          |   11 ++++--
>  tests/fate/audio.mak          |    7 +++-
>  tests/fate/dpcm.mak           |   30 ++++++++++---------
>  tests/fate/ea.mak             |   15 ++++++----
>  tests/fate/fft.mak            |    1 +
>  tests/fate/image.mak          |   22 +++++++++-----
>  tests/fate/indeo.mak          |   11 ++++--
>  tests/fate/lossless-video.mak |    7 +++-
>  tests/fate/microsoft.mak      |   27 ++++++++++++------
>  tests/fate/mpc.mak            |    9 ++++--
>  tests/fate/pcm.mak            |   25 +++++++++-------
>  tests/fate/qt.mak             |   23 ++++++++------
>  tests/fate/qtrle.mak          |   17 ++++++----
>  tests/fate/real.mak           |   11 ++++--
>  tests/fate/screen.mak         |   40 +++++++++++++++++---------
>  tests/fate/utvideo.mak        |   19 +++++++-----
>  tests/fate/video.mak          |   62 ++++++++++++++++++++++++++++------------
>  tests/fate/voice.mak          |    7 +++-
>  tests/fate/vpx.mak            |    7 +++-
>  tests/fate/wma.mak            |   18 ++++++++----
>  23 files changed, 267 insertions(+), 159 deletions(-)
>
> diff --git a/tests/fate/ac3.mak b/tests/fate/ac3.mak
> index 255479a..78d875a 100644
> --- a/tests/fate/ac3.mak
> +++ b/tests/fate/ac3.mak

[...]

> +FATE_TESTS += $(FATE_AC-3)
> +fate-ac-3: $(FATE_AC-3)

Please call the group target fate-ac3.  That's what everybody would
guess, and the contained tests all use 'ac3'.  That the codec is somehow
(officially?) call AC-3 with a hyphen isn't particularly relevant.

[...]

> diff --git a/tests/fate/ea.mak b/tests/fate/ea.mak
> index 1e628f4..c1e7f94 100644
> --- a/tests/fate/ea.mak
> +++ b/tests/fate/ea.mak
> @@ -1,17 +1,20 @@
> -FATE_TESTS += fate-ea-cdata
> +FATE_EA += fate-ea-cdata
>  fate-ea-cdata: CMD = md5 -i 
> $(SAMPLES)/ea-cdata/166b084d.46410f77.0009b440.24be960c.cdata -f s16le
>
> -FATE_TESTS += fate-ea-cmv
> +FATE_EA += fate-ea-cmv
>  fate-ea-cmv: CMD = framecrc -i $(SAMPLES)/ea-cmv/TITLE.CMV -vsync 0 -pix_fmt 
> rgb24
>
> -FATE_TESTS += fate-ea-dct
> +FATE_EA += fate-ea-dct
>  fate-ea-dct: CMD = framecrc -idct simple -i 
> $(SAMPLES)/ea-dct/NFS2Esprit-partial.dct
>
> -FATE_TESTS += fate-ea-tgq
> +FATE_EA += fate-ea-tgq
>  fate-ea-tgq: CMD = framecrc -i $(SAMPLES)/ea-tgq/v27.tgq -an
>
> -FATE_TESTS += fate-ea-tgv-ima-ea-eacs
> +FATE_EA += fate-ea-tgv-ima-ea-eacs
>  fate-ea-tgv-ima-ea-eacs: CMD = framecrc -i 
> $(SAMPLES)/ea-tgv/INTRO8K-partial.TGV -pix_fmt rgb24
>
> -FATE_TESTS += fate-ea-tgv-ima-ea-sead
> +FATE_EA += fate-ea-tgv-ima-ea-sead
>  fate-ea-tgv-ima-ea-sead: CMD = framecrc -i $(SAMPLES)/ea-tgv/INTEL_S.TGV 
> -pix_fmt rgb24
> +
> +FATE_TESTS += $(FATE_EA)
> +fate-ea: $(FATE_EA)

These are mostly unrelated codecs only connected by a common publisher.
They share no more code than any other randomly selected codecs, so
there's no reason to be testing this particular set only.


[...]

> diff --git a/tests/fate/qt.mak b/tests/fate/qt.mak
> index 9b25306..6a9f024 100644
> --- a/tests/fate/qt.mak
> +++ b/tests/fate/qt.mak
> @@ -7,36 +7,39 @@ fate-qdm2: CMP = oneoff
>  fate-qdm2: REF = $(SAMPLES)/qt-surge-suite/surge-2-16-B-QDM2.pcm
>  fate-qdm2: FUZZ = 2
>
> -FATE_TESTS += fate-qt-alaw-mono
> +FATE_QT += fate-qt-alaw-mono
>  fate-qt-alaw-mono: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-1-16-B-alaw.mov -f s16le
>
> -FATE_TESTS += fate-qt-alaw-stereo
> +FATE_QT += fate-qt-alaw-stereo
>  fate-qt-alaw-stereo: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-2-16-B-alaw.mov -f s16le
>
> -FATE_TESTS += fate-qt-ima4-mono
> +FATE_QT += fate-qt-ima4-mono
>  fate-qt-ima4-mono: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-1-16-B-ima4.mov -f s16le
>
> -FATE_TESTS += fate-qt-ima4-stereo
> +FATE_QT += fate-qt-ima4-stereo
>  fate-qt-ima4-stereo: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-2-16-B-ima4.mov -f s16le
>
> -FATE_TESTS += fate-qt-mac3-mono
> +FATE_QT += fate-qt-mac3-mono
>  fate-qt-mac3-mono: CMD = md5 -i $(SAMPLES)/qt-surge-suite/surge-1-8-MAC3.mov 
> -f s16le
>
> -FATE_TESTS += fate-qt-mac3-stereo
> +FATE_QT += fate-qt-mac3-stereo
>  fate-qt-mac3-stereo: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-2-8-MAC3.mov -f s16le
>
> -FATE_TESTS += fate-qt-mac6-mono
> +FATE_QT += fate-qt-mac6-mono
>  fate-qt-mac6-mono: CMD = md5 -i $(SAMPLES)/qt-surge-suite/surge-1-8-MAC6.mov 
> -f s16le
>
> -FATE_TESTS += fate-qt-mac6-stereo
> +FATE_QT += fate-qt-mac6-stereo
>  fate-qt-mac6-stereo: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-2-8-MAC6.mov -f s16le
>
> -FATE_TESTS += fate-qt-ulaw-mono
> +FATE_QT += fate-qt-ulaw-mono
>  fate-qt-ulaw-mono: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-1-16-B-ulaw.mov -f s16le
>
> -FATE_TESTS += fate-qt-ulaw-stereo
> +FATE_QT += fate-qt-ulaw-stereo
>  fate-qt-ulaw-stereo: CMD = md5 -i 
> $(SAMPLES)/qt-surge-suite/surge-2-16-B-ulaw.mov -f s16le
>
> +FATE_TESTS += $(FATE_QT)
> +fate-qt: $(FATE_QT)

Some of these (alaw/ulaw) are usually regarded as PCM variants, and I
doubt ima4 (whatever it is) has much in common with mac3/6.

A case could be made for a group test of *all* quicktime format files,
but that's a different matter.

-- 
Måns Rullgård
m...@mansr.com
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to