On Sat, Jan 14, 2012 at 04:21:05PM +0100, Diego Biurrun wrote:
> On Fri, Jan 13, 2012 at 02:25:15PM -0600, Daniel Huang wrote:
> >
> > --- a/libavformat/mov.c
> > +++ b/libavformat/mov.c
> > @@ -731,9 +733,11 @@ static int mov_read_mdhd(MOVContext *c, AVIOContext
> > *pb, MOVAtom atom)
> > version = avio_r8(pb);
> > - if (version > 1)
> > - return -1; /* unsupported */
> > -
> > + if (version > 1) {
> > + av_log_ask_for_sample(c, "unsupported version %d\n",
> > + version);
> > + return AVERROR_PATCHWELCOME; /* unsupported */
> > + }
>
> The line is short enough, no need to break it. Also, the comment
> is redundant.
>
> I'll queue the patch with this changed in a moment.
This breaks FATE, try
make fate-seek-lavf_mxf
make fate-seek-lavf_mxf_d10
Try backing out some of your changes to mxfdec.c until the failure
goes away.
Please also fix the small issues I mentioned above in your next patch
iteration.
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
