On Fri, Jan 13, 2012 at 09:28:35PM +0000, Paul B Mahol wrote: > On 1/13/12, Maans Rullgaard <m...@mansr.com> wrote: > > Paul B Mahol <one...@gmail.com> writes: > > > >> On 1/13/12, Maans Rullgaard <m...@mansr.com> wrote: > >>> "Justin Ruggles " <g...@libav.org> writes: > >>> > >>>> +# fate-targa-conformance-CCM8: CMD = framecrc -i > >>>> $(SAMPLES)/targa-conformance/CCM8.TGA > >>>> +# fate-targa-conformance-UCM8: CMD = framecrc -i > >>>> $(SAMPLES)/targa-conformance/UCM8.TGA > >>> > >>> WTF are those lines doing there? Whatever happened to actually > >>> reviewing patches instead of auto-replying "OK"? Yes, I know it takes > >>> more effort. > >> > >> They are commented until targa decoder can handle them. > > > > Then they do not belong there at all. > > I beg to differ.
Please be constructive. Just stating blanket disagreement or disapproval without reasons is not constructive. If you have specific arguments in favor or against a patch or change, we will be glad to hear them. Regarding the changes in this commit, I agree that no commented-out code AKA cruft should be added to the build system. Thank you, Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
