On Fri, 20 Jan 2012 10:58:41 +0100, Reinhard Tartler <siret...@tauware.de> wrote: > On Mi, Jan 18, 2012 at 23:25:04 (CET), Ronald S. Bultje wrote: > > > OK, so it can crash. What's the use case of draw_horiz_band if > > threading is enabled? Shouldn't the whole callback never be used, > > since we force codec delay? Is there a valid use case where the > > user-supplied draw_horiz_band should be called while threading is > > active and enabled? > > > > If not, we shouldn't revert the default back to 1 thread, but we > > should disable draw_horiz_band calls when threading is enabled. After > > all, threading gives a much bigger speed benefit than draw_horiz_band. > > Another reason for reverting the default back to 1 thread might be to > avoid crashes with applications that use hwaccel, like vlc/vaapi: > > http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=656572 >
+1, it obviously causes a number of issues so we should reset it back to 1 at least for 0.8. -- Anton Khirnov _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
