Hi, (old patch review.)
On Wed, Jan 18, 2012 at 10:25 AM, Diego Biurrun <[email protected]> wrote: [..] > @@ -41,106 +42,104 @@ altivec_packIntArrayToCharArray(int *val, uint8_t* > dest, int dstW) [..] > + for (i = 0; (i < dstW) && Remove brackets around "i < dstW". > + for (; i < (dstW - 15); i += 16) { Same around "dstW - 15". > + for (i = 0; i < (dstW - 15); i += 16) { Same. > + for (i = 0; i < (dstW - 7); i += 8) { Likewise. > - vector signed short src_vA = // vec_unpackh sign-extends... > - (vector signed short)(vec_mergeh((vector unsigned > char)vzero, src_vF)); > - vector signed short src_vB = // vec_unpackh sign-extends... > - (vector signed short)(vec_mergel((vector unsigned > char)vzero, src_vF)); > + vector signed short src_vA = // vec_unpackh sign-extends... > + (vector signed > short)(vec_mergeh((vector unsigned char)vzero, src_vF)); > + vector signed short src_vB = // vec_unpackh sign-extends... > + (vector signed > short)(vec_mergel((vector unsigned char)vzero, src_vF)); Hm, can you elaborate on this? > diff --git a/libswscale/ppc/yuv2rgb_altivec.c > b/libswscale/ppc/yuv2rgb_altivec.c Sorry sleep time. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
