On Thu, Feb 02, 2012 at 06:32:33PM +0100, Diego Biurrun wrote:
> On Thu, Feb 02, 2012 at 05:09:13PM +0000, Paul B Mahol wrote:
> > On 2/2/12, Diego Biurrun <[email protected]> wrote:
> > > On Wed, Feb 01, 2012 at 08:23:32PM +0000, Paul B Mahol wrote:
> > >>
> > >> --- a/libavcodec/frwu.c
> > >> +++ b/libavcodec/frwu.c
> > >> @@ -28,7 +28,7 @@ static av_cold int decode_init(AVCodecContext *avctx)
> > >>  {
> > >>      if (avctx->width & 1) {
> > >>          av_log(avctx, AV_LOG_ERROR, "FRWU needs even width\n");
> > >> -        return -1;
> > >> +        return AVERROR_INVALIDDATA;
> > >
> > > This is not HEAD, what did you create your patch against?
> > 
> > This is already pushed.
> 
> No, it is not, the rest of the patch applies,

Scratch this nonsense - apparently the commit notification email was
lost due to exceeding mail quota.

> only here we have AVERROR(EINVAL) instead of -1. However, I believe
> AVERROR_INVALIDDATA is more correct here, as the value is not
> user-supplied.

I think this is true nonetheless, but whatever ..

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to