On Wed, Feb 01, 2012 at 05:10:22PM +0100, Diego Biurrun wrote:
> On Wed, Feb 01, 2012 at 07:38:55AM -0800, Ronald S. Bultje wrote:
> > 
> > --- /dev/null
> > +++ b/libswscale/input.c
> > @@ -0,0 +1,760 @@
> > +
> > +#include <inttypes.h>
> 
> stdint.h is enough.
> 
> > +#include <string.h>
> > +#include <math.h>
> > +#include <stdio.h>
> > +#include "config.h"
> > +#include <assert.h>
> > +#include "swscale.h"
> > +#include "swscale_internal.h"
> > +#include "rgb2rgb.h"
> > +#include "libavutil/intreadwrite.h"
> > +#include "libavutil/cpu.h"
> > +#include "libavutil/avutil.h"
> > +#include "libavutil/mathematics.h"
> > +#include "libavutil/bswap.h"
> > +#include "libavutil/pixdesc.h"
> 
> Separate local from system headers by an empty line, move libavutil
> headers before swscale ones.
> 
> The rest looks good in principle, assuming you only moved code around.

Pushed with that changed as we agreed to at FOSDEM.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to