On 02/07/2012 12:28 PM, Anton Khirnov wrote: > > On Tue, 07 Feb 2012 11:31:20 -0500, Justin Ruggles <justin.rugg...@gmail.com> > wrote: >> On 02/05/2012 03:16 PM, Anton Khirnov wrote: >> >>> It more accurately describes what does this variable store. >>> --- >>> avconv.c | 31 ++++++++++++++++--------------- >>> 1 files changed, 16 insertions(+), 15 deletions(-) >> >> >> The naming is still a bit confusing. Having "last_dts" and "next_dts" >> somehow implies the stream has no "current" state. "last" can be >> intrepreted to mean "previous" or "most recent" depending on the >> context. I think renaming it to "current_dts" or just "dts" might be >> easier to comprehend. >> > > Well now it's clearly documented what exactly does it mean -- last > packet that went into the decoder. I think that using "current" is OTOH > more confusing. E.g. when we're picking the file to read from next, it's > not immediately clear what does "current" dts mean. > > (yay, a bikeshed)
I suppose the patch is ok. At least it is documented. -Justin _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
