On 2012-02-13 11:07:02 +0200, Martin Storsjö wrote: > On Sun, 12 Feb 2012, Janne Grunau wrote: > > >On 2012-02-12 22:53:43 +0200, Martin Storsjö wrote: > >>On Wed, 8 Feb 2012, Jason Garrett-Glaser wrote: > >> > >>>On Wed, Feb 8, 2012 at 8:07 AM, Luca Barbato <[email protected]> wrote: > >>>>On 2/8/12 5:04 AM, Martin Storsjö wrote: > >>>>> > >>>>>From: Matthew Szatmary<[email protected]> > >>>>> > >>>>>The mpegts muxer assumes/requires 4 byte startcodes for annex b data. > >>> > >>>Wouldn't it be better to fix the MPEG-TS muxer? > > > >It's not broken, it checks for the zero_byte required for the first NAL > >unit of an access unit. > > > >>Jason - when I tried to fix this in the mpegts muxer, in > >>http://patches.libav.org/patch/16727/, Gil pointed out that some > >>standards require the startcodes to be 4 bytes. Given this, are you > >>ok with this change? > > > >It's easier (and not invalid) to always put an extra zero byte before > >the start code prefix (0x000001) than adding it just in the cases were > >the zero_byte is required. > > I take this as an implicit ok. :-) I'll push this later today unless > someone has more objections.
ok with later == this evening CET Janne _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
