On 2/18/12 12:56 AM, Martin Storsjö wrote:
From: Michael Niedermayer<[email protected]>

This fixes valgrind warnings about using uninitialized data
(bug 181).

Why that happens? And more importantly, if ff_chroma_inter_body_mmxext gets inlined it should be stated in the comment.

I doubt that function will be changed but still, looks strange.

lu

---
  libavcodec/x86/h264_deblock.asm |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/libavcodec/x86/h264_deblock.asm b/libavcodec/x86/h264_deblock.asm
index f264edb..8335177 100644
--- a/libavcodec/x86/h264_deblock.asm
+++ b/libavcodec/x86/h264_deblock.asm
@@ -835,7 +835,11 @@ cglobal deblock_h_chroma_8_mmxext, 5,7
      TRANSPOSE4x8_LOAD  bw, wd, dq, PASS8ROWS(t5, r0, r1, t6)
      movq  buf0, m0
      movq  buf1, m3
-    call ff_chroma_inter_body_mmxext
+    LOAD_MASK  r2d, r3d
+    movd       m6, [r4] ; tc0
+    punpcklbw  m6, m6
+    pand       m7, m6
+    DEBLOCK_P0_Q0
      movq  m0, buf0
      movq  m3, buf1
      TRANSPOSE8x4B_STORE PASS8ROWS(t5, r0, r1, t6)

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to