2012/2/23 Ronald S. Bultje <[email protected]>:
> Let's change the argument to intptr_t, the caller can likely do this for free.

Done in patch 0005 (which I include here just to make sure they are
applied in the correct order).

[...]
> Is that faster? It saves one add and one sub in the loop, at the cost
> of more complex movh/movus.

Yes it does, to my surprise (another equivalent try for rv40 asm
yielded a worsened result), as it brings it to 57 cycles down from 69.

> Also, can the movu be changed to a mova,
> i.e. can we somehow guarantee alignment?

No, in the call at line 1605 of aacsbr.c:
sbr->dsp.hf_g_filt(Y[1][i] + kx, ...
kx can be odd, which makes the address at best 8bytes-aligned, like
Mans reported.

Christophe

Attachment: 0005-SBR-DSP-use-intptr_t-for-the-ixh-parameter.patch
Description: Binary data

Attachment: 0006-SBR-DSP-x86-implement-SSE-sbr_hf_g_filt.patch
Description: Binary data

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to