Justin Ruggles <justin.rugg...@gmail.com> writes:
> On 03/12/2012 10:18 AM, Måns Rullgård wrote:
>
>> Justin Ruggles <justin.rugg...@gmail.com> writes:
>>
>>> This will allow comparison to original pre-encoded content instead of
>>> comparing to expected decoded output.
>>> ---
>>> tests/Makefile | 2 +-
>>> tests/fate-run.sh | 16 ++++++++++++----
>>> 2 files changed, 13 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/tests/Makefile b/tests/Makefile
>>> index 79bbba5..7cb39ff 100644
>>> --- a/tests/Makefile
>>> +++ b/tests/Makefile
>>> @@ -116,7 +116,7 @@ fate: $(FATE)
>>>
>>> $(FATE): avconv$(EXESUF) $(FATE_UTILS:%=tests/%$(HOSTEXESUF))
>>> @echo "TEST $(@:fate-%=%)"
>>> - $(Q)$(SRC_PATH)/tests/fate-run.sh $@ "$(SAMPLES)" "$(TARGET_EXEC)"
>>> "$(TARGET_PATH)" '$(CMD)' '$(CMP)' '$(REF)' '$(FUZZ)' '$(THREADS)'
>>> '$(THREAD_TYPE)' '$(CPUFLAGS)' '$(PSNR_SHIFT)'
>>> + $(Q)$(SRC_PATH)/tests/fate-run.sh $@ "$(SAMPLES)" "$(TARGET_EXEC)"
>>> "$(TARGET_PATH)" '$(CMD)' '$(CMP)' '$(REF)' '$(FUZZ)' '$(THREADS)'
>>> '$(THREAD_TYPE)' '$(CPUFLAGS)' '$(PSNR_SHIFT)' '$(PSNR_TARGET)'
>>>
>>> fate-list:
>>> @printf '%s\n' $(sort $(FATE))
>>> diff --git a/tests/fate-run.sh b/tests/fate-run.sh
>>> index 2f882c0..90dc61a 100755
>>> --- a/tests/fate-run.sh
>>> +++ b/tests/fate-run.sh
>>> @@ -19,6 +19,7 @@ threads=${9:-1}
>>> thread_type=${10:-frame+slice}
>>> cpuflags=${11:-all}
>>> psnr_shift=${12:-0}
>>> +psnr_target=${13:-0}
>>
>> The naming of those variables is a little confusing since they are used
>> for other things than psnr. In fact, none of the tests use the psnr
>> value printed.
>
> It's the target value to compare to the output from tiny_psnr...
It could be argued that tiny_psnr is badly named too.
> That's why I called it that. It's used for both stddev and MAXDIFF.
> Other name suggestions?
cmp_target to go with the $cmp variable?
--
Måns Rullgård
m...@mansr.com
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
