On Sun, Mar 18, 2012 at 05:50:02PM +0100, Diego Biurrun wrote: > On Fri, Mar 09, 2012 at 04:05:34PM +0100, Diego Biurrun wrote: > > On Fri, Mar 09, 2012 at 03:01:43PM +0000, Måns Rullgård wrote: > > > Diego Biurrun <[email protected]> writes: > > > > --- a/libavcodec/x86/dsputil_mmx.c > > > > +++ b/libavcodec/x86/dsputil_mmx.c > > > > @@ -2337,6 +2337,7 @@ extern void > > > > ff_butterflies_float_interleave_avx(float *dst, const float *src0, > > > > const float *src1, int > > > > len); > > > > > > > > #define SET_QPEL_FUNCS(PFX, IDX, SIZE, CPU, PREFIX) \ > > > > + do { > > > > \ > > > > c->PFX ## _pixels_tab[IDX][ 0] = PREFIX ## PFX ## SIZE ## _mc00_ > > > > ## CPU; \ > > > > c->PFX ## _pixels_tab[IDX][ 1] = PREFIX ## PFX ## SIZE ## _mc10_ > > > > ## CPU; \ > > > > c->PFX ## _pixels_tab[IDX][ 2] = PREFIX ## PFX ## SIZE ## _mc20_ > > > > ## CPU; \ > > > > @@ -2352,25 +2353,32 @@ extern void > > > > ff_butterflies_float_interleave_avx(float *dst, const float *src0, > > > > c->PFX ## _pixels_tab[IDX][12] = PREFIX ## PFX ## SIZE ## _mc03_ > > > > ## CPU; \ > > > > c->PFX ## _pixels_tab[IDX][13] = PREFIX ## PFX ## SIZE ## _mc13_ > > > > ## CPU; \ > > > > c->PFX ## _pixels_tab[IDX][14] = PREFIX ## PFX ## SIZE ## _mc23_ > > > > ## CPU; \ > > > > - c->PFX ## _pixels_tab[IDX][15] = PREFIX ## PFX ## SIZE ## _mc33_ > > > > ## CPU > > > > + c->PFX ## _pixels_tab[IDX][15] = PREFIX ## PFX ## SIZE ## _mc33_ > > > > ## CPU; \ > > > > + } while (0); > > > > > > Wrong indentation. There are several acceptable forms for such macros. > > > This is not one of them. > > > > The indentation of these macros is fixed in the subsequent cosmetics > > patch, so I left it out from this one. Don't worry, this will not be > > left as-is. > > ping
OKed by Kostya on IRC. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
