On Wed, 4 Apr 2012, Luca Barbato wrote:
On 03/04/12 12:27, Martin Storsjö wrote:
On Tue, 3 Apr 2012, Luca Barbato wrote:
It must be extended to support subtitle-like features.
---
libavformat/flvdec.c | 6 +++---
libavformat/flvenc.c | 8 ++++----
2 files changed, 7 insertions(+), 7 deletions(-)
Doesn't this (at least partially) change stuff added in the previous
patch? Shouldn't those parts be squashed into that one then? Also, the
summary line could use a few more words to say what marker it is about.
Indeed they will be squashed, the question is mostly on what we should
support and how.
Ok.
I haven't had time to look closer at this yet, but it could also be worth
mentioning in the commit messages, that this isn't an existing feature
used by any other flv compatible sw, but a completely new
feature/behaviour within that spec. That (at least for me) changes how to
relate to the patch a little bit.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
