On Wed, Apr 04, 2012 at 05:51:39PM +0200, Anton Khirnov wrote: > > On Wed, 04 Apr 2012 10:16:08 -0400, Justin Ruggles <[email protected]> > wrote: > > On 04/03/2012 02:47 AM, Anton Khirnov wrote: > > > > > - if (st->codec->strict_std_compliance <= > > > FF_COMPLIANCE_UNOFFICIAL) { > > > - if (st->codec->codec_id == CODEC_ID_MJPEG) { > > > - p = (const enum PixelFormat[]) { PIX_FMT_YUVJ420P, > > > PIX_FMT_YUVJ422P, PIX_FMT_YUV420P, PIX_FMT_YUV422P, PIX_FMT_NONE }; > > > - } else if (st->codec->codec_id == CODEC_ID_LJPEG) { > > > - p = (const enum PixelFormat[]) { PIX_FMT_YUVJ420P, > > > PIX_FMT_YUVJ422P, PIX_FMT_YUVJ444P, PIX_FMT_YUV420P, > > > - PIX_FMT_YUV422P, > > > PIX_FMT_YUV444P, PIX_FMT_BGRA, PIX_FMT_NONE }; > > > - } > > > - } > > > > > > Your patch removes this. Can you explain why? > > > > This code is broken -- strict_std_compliance is not set at this point. > Since nobody complained, I assume nobody cares. > > And in any case, this belongs in encoder, not avconv.
Possibly this could be split then; at least a note in the log message about this fact would be appreciated. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
