On Sun, 8 Apr 2012, Samuel Pitoiset wrote:
@@ -56,12 +59,13 @@ typedef enum {
/** protocol handler context */
typedef struct RTMPContext {
+ AVClass *class;
I think this normally is const AVClass *class, but it shouldn't matter
much.
@@ -847,6 +852,16 @@ static int rtmp_open(URLContext *s, const char *uri, int
flags)
rt->chunk_size = 128;
rt->state = STATE_HANDSHAKED;
+
+ // Keep the application name when it has been defined by the user.
+ old_app = (rt->app) ? av_strdup(rt->app) : NULL;
The parentheses around rt->app are superfluous, we generally leave them
out in our coding style.
Other than that, this looks quite good - no need to resend the patch if
there's nothing else. But please look up the parameter handling I
mentioned in the other mail.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
