On 04/12/2012 09:31 PM, Alex Converse wrote:

> ---
>  libavcodec/tiff.c |  263 
> +++++++++++++++++++++++++++++++----------------------
>  1 files changed, 154 insertions(+), 109 deletions(-)
> 
> diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
> index 26304ca..36630a2 100644
> --- a/libavcodec/tiff.c
> +++ b/libavcodec/tiff.c
[...]
>              case TIFF_BYTE:
> -                s->bpp = (off & 0xFF) + ((off >> 8) & 0xFF) + ((off >> 16) & 
> 0xFF) + ((off >> 24) & 0xFF);
> +                s->bpp =
> +                    (off & 0xFF) + ((off >> 8) & 0xFF) + ((off >> 16) & 
> 0xFF) +
> +                    ((off >> 24) & 0xFF);

that one looks weird.

> -        if(tiff_unpack_strip(s, dst, stride, orig_buf + soff, ssize, 
> FFMIN(s->rps, s->height - i)) < 0)
> +        if (tiff_unpack_strip
> +            (s, dst, stride, orig_buf + soff, ssize,
> +             FFMIN(s->rps, s->height - i)) < 0)


that one looks weirder.

the rest LGTM.

-Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to