On Friday, May 4, 2012, Måns Rullgård <m...@mansr.com> wrote:
> Sean McGovern <gsean...@gmail.com> writes:
>
>> Also merge POWER3 and POWER4 configuration together with the additions.
>> ---
>>  configure |    5 ++++-
>>  1 files changed, 4 insertions(+), 1 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 1dc2e3e..ed1624e 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2279,9 +2279,12 @@ elif enabled ppc; then
>>          74*|ppc74*|powerpc74*)
>>              cpuflags="-mcpu=7400 -mpowerpc-gfxopt"
>>          ;;
>> -        g5|970|ppc970|powerpc970|power4*)
>> +        g5|970|ppc970|powerpc970)
>>              cpuflags="-mcpu=970 -mpowerpc-gfxopt -mpowerpc64"
>>          ;;
>> +        power[3-7]*)
>> +            cpuflags="-mcpu=$(tolower $cpu) -mpowerpc-gfxopt
-mpowerpc64"
>
> What's with the tolower?  I think it's fair to expect of people to type
> the name in lowercase.  The case-insensitive matching was mainly added
> for the Gx names, which I can more easily see being entered in uppercase.
>

Fair enough -- I was just copying the case statement above it (not visible
in the patch). Want I fix that too?

-- Sean
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to