On Thu, 10 May 2012, Luca Barbato wrote:
On 10/05/12 11:01, Samuel Pitoiset wrote:
The context pointed by rtmp_hd/rtmp_hd_out is used for reading/writing
requests. These two streams will be used by RTMPT for HTTP tunneling.
---
libavformat/rtmpproto.c | 55 ++++++++++++++++++++++++++---------------------
1 file changed, 30 insertions(+), 25 deletions(-)
the concept doesn't seem wrong,
The patchset in itself looks good, although it (or at least the third)
doesn't really make sense to apply before you have the following patches
done too.
Also, I'd prefer to have commit message changed to something like this:
---8<----
rtmp: Split the lower level urlcontext into two variables
One urlcontext is used for reading, the other for writing. This is in
preparation for adding HTTP tunneling later.
---8<----
Or something along those lines.
just the name might be changed to stream and tunnel or something more
descriptive.
Having different names like that (naming one stream and the other tunnel)
would only be confusing to me, but rtmp_hd and rtmp_out_hd aren't perhaps
the best choices. (The choice of names in rtsp come from the fact that the
single one was named rtsp_hd originally, and the other one was added as
rtsp_out_hd without changing the first one.)
I'd prefer something like stream_in/stream_out, or just stream/stream_out
which avoids changing half of them.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
