Diego Biurrun <[email protected]> writes: > On Sun, May 20, 2012 at 08:33:22PM +0100, Måns Rullgård wrote: >> Luca Barbato <[email protected]> writes: >> > On 20/05/12 11:39, Måns Rullgård wrote: >> >> Diego Biurrun <[email protected]> writes: >> >> >> >>> FATE_SAMPLES is now used directly by the Makefiles, which induces the >> >>> test >> >>> system to run a test with the value of the environment variable as name. >> >>> Renaming the environment variable to LIBAV_SAMPLES avoids this problem. >> >>> --- >> >>> configure | 4 ++-- >> >>> doc/fate.texi | 2 +- >> >>> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> >> >> Fine with me. The new name makes more sense than the old one anyway. >> > >> > I'd rather have the internal one changed so people using it won't have >> > strange surprises. Anyway isn't a huge deal. > > I think the impact will be low, so I'm in favor of changing the name. > >> I suggest we reserve FATE_* for internal use. That will avoid any such >> mishaps in future. > > I like the idea. Where could we document this?
In some unwritten section documenting all variables and conventions. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
