On Thu, 7 Jun 2012 11:38:43 +0200, David Girault <[email protected]> wrote: > This new decoder will allow to decode menu stream found > in m2ts files in Bluray or AVCHD HDMV disks. > > The new decoder was developped using AVMEDIA_TYPE_OVERLAY, > inspired from AVMEDIA_TYPE_SUBTITLE, since both may send > multiple decoded pictures to add to video currently > displayed. > > version 4: > - Added some fixes for x264 demo disk that have button without > picture. > - Change palette conversion to avoid convertion in avplay. > > Signed-off-by: David Girault <[email protected]> > ---
I'm a bit concerned about adding a new media type for this highly specific feature. I'm not rejecting it, but it needs more thought/discussion. Especially since the API is very similar to subtitles. Perhaps we could just extend the subtitle API. >From my quick glance through the patchset, it seems that the main (only?) difference from subs is that those menus are interactive. If I'm reading it correctly, you're implementing interactivity by the player constructing its own packets. The first point here is that this is also public API and thus needs to be documented. The second is that this approach looks quite hacky to me. Using packet side data might be better. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
