On Tue, Jun 12, 2012 at 10:32:29PM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > On Tue, Jun 12, 2012 at 09:33:02AM +0100, Måns Rullgård wrote: > >> Diego Biurrun <[email protected]> writes: > >> > >> > This keeps complexity localized in one place and allows using the OBJDIRS > >> > variable in any place without having to drop duplicates from it. > >> > --- > >> > Makefile | 2 +- > >> > common.mak | 2 +- > >> > 2 files changed, 2 insertions(+), 2 deletions(-) > >> > >> Does this solve an actual problem? > > > > The one described in the log message. > > That's not what I call an actual problem. Is something currently broken?
Correctness is a goal in itself. I'm surprised to hear this from you of all people :) > > IMNSHO we simply added the $(sort) call to get rid of the duplicate > > directory entries in the wrong place to begin with. > > Your patch doesn't seem to necessarily remove all duplicates. Unless I'm very badly mistaken it does right now. I could of course move the $(sort) call outward to cover the manually added entries. One day there might indeed be duplicates otherwise. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
