Martin Storsjö <[email protected]> writes: > On Thu, 21 Jun 2012, Diego Biurrun wrote: > >> On Wed, Jun 20, 2012 at 06:28:16PM -0700, Ronald S. Bultje wrote: >>> On Wed, Jun 20, 2012 at 6:23 PM, Diego Biurrun <[email protected]> wrote: >>>> On Wed, Jun 20, 2012 at 10:25:00AM -0700, Ronald S. Bultje wrote: >>>>> >>>>> --- a/libavformat/ivfdec.c >>>>> +++ b/libavformat/ivfdec.c >>>>> @@ -87,5 +87,5 @@ AVInputFormat ff_ivf_demuxer = { >>>>> .flags = AVFMT_GENERIC_INDEX, >>>>> - .codec_tag = (const AVCodecTag*[]){ ff_codec_bmp_tags, 0 }, >>>>> + .codec_tag = (const AVCodecTag* const []){ ff_codec_bmp_tags, 0 >>>>> }, >>>> >>>> This looks correct but incomplete. You appear to have overlooked the >>>> missing const in cafdec.c. >>> >>> The patch starts with "ivf", so it seems unrelated. >> >> So change the log message. Why would you not want to fix this issue >> in all places instead of just one? > > FWIW, the cafdec.c case also messes up the MSVC converter, not just > the one in ivfdec (since it's the same issue, obviously).
Both should be fixed regardless. One patch or two, I don't really care. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
