On Sun, Jun 24, 2012 at 12:34:52PM +0100, Mans Rullgard wrote: > --- a/libavutil/x86/cpu.c > +++ b/libavutil/x86/cpu.c > @@ -147,14 +146,18 @@ int ff_get_cpu_flags_x86(void) > > - /* 6/9 (pentium-m "banias"), 6/13 (pentium-m "dothan"), and 6/14 > (core1 "yonah") > - * theoretically support sse2, but it's usually slower than mmx, > - * so let's just pretend they don't. AV_CPU_FLAG_SSE2 is disabled > and > - * AV_CPU_FLAG_SSE2SLOW is enabled so that SSE2 is not used unless > - * explicitly enabled by checking AV_CPU_FLAG_SSE2SLOW. The same > - * situation applies for AV_CPU_FLAG_SSE3 and > AV_CPU_FLAG_SSE3SLOW. */ > - if (rval & AV_CPU_FLAG_SSE2) rval ^= > AV_CPU_FLAG_SSE2SLOW|AV_CPU_FLAG_SSE2; > - if (rval & AV_CPU_FLAG_SSE3) rval ^= > AV_CPU_FLAG_SSE3SLOW|AV_CPU_FLAG_SSE3; > + /* 6/9 (pentium-m "banias"), 6/13 (pentium-m "dothan"), and > + * 6/14 (core1 "yonah") theoretically support sse2, but it's > + * usually slower than mmx, so let's just pretend they don't. > + * AV_CPU_FLAG_SSE2 is disabled and AV_CPU_FLAG_SSE2SLOW is > + * enabled so that SSE2 is not used unless explicitly enabled > + * by checking AV_CPU_FLAG_SSE2SLOW. The same situation > + * applies for AV_CPU_FLAG_SSE3 and AV_CPU_FLAG_SSE3SLOW. > + */
Keep the "*/" at the end of the line, like in the other comment blocks. LGTM otherwise. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
