On Wed, Jul 11, 2012 at 08:00:43AM +0200, Kostya Shishkov wrote:
> --- /dev/null
> +++ b/libavcodec/mss4.c
> @@ -0,0 +1,680 @@
> +static int mss4_init_vlc(VLC *vlc, const uint8_t *lens, const uint8_t *syms,
> + int num_syms)
av_cold? This is only called from
> +static av_cold int mss4_init_vlcs(MSS4Context *ctx)
which is av_cold itself ...
> +/* This function returns values in range
in the range
> +static inline int get_coeff(GetBitContext *gb, VLC *vlc)
> +{
> + int val = get_vlc2(gb, vlc->table, vlc->bits, 2);
> +
> + return get_coeff_bits(gb, val);
pointless variable indirection?
> + ff_mss34_dct_put(c->imgbuf[i], 8, c->block);
> + out = dst[i] + mb_x * 16;
> + // since DCT block is coded as YUV420 and the whole frame as YUV444
> + // we need to scale chroma
the DCT block
I'd capitalize and end in a period.
> +/* Image mode - the hardest to comprehend MSS4 coding mode.
> + *
> + * In this mode all three 16x16 blocks are coded together in method remotely
in a method
> + * similar to methods employed in MSS1-MSS3.
> + * The idea is that every component has a vector of 1-4 most common symbols
> + * and escape mode for reading new value from bitstream. Decoding consists of
an escape mode - if it is a single one..
> + * retrieving pixel values from vector or reading new ones from bitstream;
from the vector, from the bitstream
> + * depending on flags read from bitstream those vector positions can be
from the bitstream, these vector positions
> + * updated or reused from the state for previous line or previous pixel.
s/for/of the/
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
