Hi,
On Mon, Jul 23, 2012 at 7:14 AM, Kostya Shishkov
<kostya.shish...@gmail.com> wrote:
> On Mon, Jul 23, 2012 at 07:11:49AM -0700, Ronald S. Bultje wrote:
>> Hi,
>>
>> On Mon, Jul 23, 2012 at 2:05 AM, Diego Biurrun <di...@biurrun.de> wrote:
>> > On Sun, Jul 22, 2012 at 08:46:10PM -0700, Ronald S. Bultje wrote:
>> >> From: "Ronald S. Bultje" <rsbul...@gmail.com>
>> >>
>> >> Write out the NAL decoding loops in full so that they are easier to
>> >> parse for a preprocessor without it having to be aware of macros or
>> >> other such things in C code.
>> >>
>> >> This also makes the code more readable.
>> >> ---
>> >> libavcodec/h264.c | 42 +++++++++++++++++++++++++-----------------
>> >> 1 file changed, 25 insertions(+), 17 deletions(-)
>> >
>> > LGTM
>> >
>> >> --- a/libavcodec/h264.c
>> >> +++ b/libavcodec/h264.c
>> >> @@ -175,42 +175,50 @@ const uint8_t *ff_h264_decode_nal(H264Context *h,
>> >> const uint8_t *src,
>> >>
>> >> +#define STARTCODE_TEST \
>> >> + if (i + 2 < length && src[i + 1] == 0 && src[i + 2] <= 3) { \
>> >> + if (src[i + 2] != 3) { \
>> >> + /* startcode, so we must be past the end */ \
>> >> + length = i; \
>> >> + } \
>> >> + break; \
>> >> + }
>> >> #if HAVE_FAST_UNALIGNED
>> >> +#define FIND_FIRST_ZERO \
>> >> + if (i > 0 && !src[i]) \
>> >> + i--; \
>> >> + while (src[i]) \
>> >> + i++
>> >
>> > h264.c is one of the pretty files now, so please align the '\',
>> > preferably on column 72.
>>
>> My editor doesn't support that - can you do that?
>
> Mine neither, but pressing spacebar and releasing it after some time does the
> trick just fine.
Hard to say if it's at 72 or not, is it?
Ronald
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
