Hi, On Fri, Jul 27, 2012 at 2:49 PM, Diego Biurrun <di...@biurrun.de> wrote: > On Thu, Jul 26, 2012 at 08:54:30PM -0700, Ronald S. Bultje wrote: >> --- a/libavcodec/x86/h264_idct_10bit.asm >> +++ b/libavcodec/x86/h264_idct_10bit.asm >> @@ -72,25 +72,25 @@ SECTION .text >> ;;;;;;; NO FATE SAMPLES TRIGGER THIS >> -%macro ADD4x4IDCT 1 >> -add4x4_idct_%1: >> +%macro ADD4x4IDCT 0 >> +add4x4_idct_ %+ SUFFIX: >> add r5, r0 >> @@ -107,28 +107,28 @@ add4x4_idct_%1: >> >> %macro ADD16_OP 3 >> cmp byte [r4+%3], 0 >> jz .skipblock%2 >> mov r5d, [r1+%2*4] >> - call add4x4_idct_%1 >> + call add4x4_idct_ %+ SUFFIX > > You don't need this SUFFIX mangling, same below.
We're not using cglobal for the called labels (they're not functions), so function_defined is not set, so call suffix completion doesn't work. Thus, yes, we need the SUFFIX (without _, fixed locally) or else it'll simply not compile. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
