On Tue, Jul 31, 2012 at 11:51:19AM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > On Tue, Jul 31, 2012 at 11:26:48AM +0100, Måns Rullgård wrote: > >> "Ronald S. Bultje " <[email protected]> writes: > >> > @@ -344,12 +196,12 @@ void ff_h264dsp_init_x86(H264DSPContext *c, const > >> > int bit_depth, const int chrom > >> > { > >> > > >> > +#if HAVE_YASM > >> > if (chroma_format_idc == 1 && mm_flags & AV_CPU_FLAG_MMX2) { > >> > - c->h264_loop_filter_strength= h264_loop_filter_strength_mmx2; > >> > + c->h264_loop_filter_strength = > >> > ff_h264_loop_filter_strength_mmx2; > >> > } > >> > > >> > if (bit_depth == 8) { > >> > -#if HAVE_YASM > >> > if (mm_flags & AV_CPU_FLAG_MMX) { > >> > c->h264_idct_dc_add = > >> > c->h264_idct_add = ff_h264_idct_add_8_mmx; > >> > @@ -510,6 +362,6 @@ void ff_h264dsp_init_x86(H264DSPContext *c, const > >> > int bit_depth, const int chrom > >> > #endif /* HAVE_AVX */ > >> > } > >> > } > >> > -#endif > >> > } > >> > +#endif > >> > } > >> > >> This broke builds without yasm. > > > > I'm cooking up a patch to fix it. > > Simply put the whole function body under #if HAVE_YASM.
Not quite, the first function assigned to a function pointer is written in inline Assembly. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
