On Wed, Aug 1, 2012 at 12:28 AM, Ronald S. Bultje <rsbul...@gmail.com>wrote:
> Hi,
>
> On Tue, Jul 31, 2012 at 9:12 PM, Luca Barbato <lu_z...@gentoo.org> wrote:
> > @@ -2879,10 +2879,9 @@ static void dsputil_init_sse2(DSPContext *c,
> AVCodecContext *avctx,
> > int mm_flags)
> > {
> > const int bit_depth = avctx->bits_per_raw_sample;
> > -
> > -#if HAVE_INLINE_ASM
> > const int high_bit_depth = bit_depth > 8;
> >
> > +#if HAVE_INLINE_ASM
> > if (!(mm_flags & AV_CPU_FLAG_SSE2SLOW)) {
> > // these functions are slower than mmx on AMD, but faster on
> Intel
> > if (!high_bit_depth) {
> > @@ -2893,7 +2892,9 @@ static void dsputil_init_sse2(DSPContext *c,
> AVCodecContext *avctx,
> > H264_QPEL_FUNCS(0, 0, sse2);
> > }
> > }
> > +#endif /* HAVE_INLINE_ASM */
>
> The H264_QPEL_FUNCS() call should go outside HAVE_INLINE_ASM.
Fixed locally.
>
> +;*****************************************************************************
> +;* MMX/SSE2/SSSE3-optimized H.264 qpel code
> >
> +;*****************************************************************************
> > +;* Copyright (C) 2012 Daniel Kang
> > +;*
> > +;* Authors: Daniel Kang <daniel.d.k...@gmail.com>
>
> You told me you based this substantially on the existing
> implementation; if that's the case, you should acknowledge the
> original author(s) of that code also.
>
Fixed locally.
Can I have access to a setup that doesn't have inlined assembly?
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
