Diego Biurrun <[email protected]> writes:

> Sorry for not commenting earlier, but ...
>
> On Sat, Aug 11, 2012 at 11:37:51AM +0200, Anton Khirnov wrote:
>> 
>> Author:    Anton Khirnov <[email protected]>
>> Committer: Anton Khirnov <[email protected]>
>> Date:      Sun Aug  5 15:18:00 2012 +0200
>> 
>> lavc: add codec descriptors.
>> 
>> They describe properties that are inherent to a codec (as described by
>> an AVCodecID) without referring to a specific implementation.
>> 
>> --- /dev/null
>> +++ b/libavcodec/codec_desc.c
>> @@ -0,0 +1,1878 @@
>> +
>> +static const AVCodecDescriptor codec_descriptors[] = {
>> +    /* video codecs */
>> +    {
>> +        .id        = AV_CODEC_ID_MPEG1VIDEO,
>> +        .type      = AVMEDIA_TYPE_VIDEO,
>> +        .name      = "mpeg1video",
>> +        .long_name = NULL_IF_CONFIG_SMALL("MPEG-1 video"),
>> +    },
>> +    {
>> +        .id        = AV_CODEC_ID_MPEG2VIDEO,
>> +        .type      = AVMEDIA_TYPE_VIDEO,
>> +        .name      = "mpeg2video",
>> +        .long_name = NULL_IF_CONFIG_SMALL("MPEG-1 video"),
>> +    },
>> +    {
>> +        .id        = AV_CODEC_ID_MPEG2VIDEO_XVMC,
>> +        .type      = AVMEDIA_TYPE_VIDEO,
>> +        .name      = "mpegvideo_xvmc",
>> +        .long_name = NULL_IF_CONFIG_SMALL("MPEG-1/2 video XvMC (X-Video 
>> Motion Compensation)"),
>
> ... this duplicates all the information from the individual AVCodec
> declarations.  This is not good.

So let's drop it from those.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to