Luca Barbato <[email protected]> writes: > On 8/12/12 8:45 PM, Mans Rullgard wrote: >> Under some circumstances, suncc will use a single register for the >> address of all memory operands, inserting lea instructions loading >> the correct address prior to each memory operand being used in the >> code. In the yadif code, the branch in the asm block bypasses such >> an lea instruction, causing an incorrect address to be used in the >> following load. >> >> This patch replaces the tmpX arrays with a single array and uses a >> register operand to hold its address. Although this prevents using >> offsets from the stack pointer to access these locations, the code >> still builds as 32-bit PIC even with old compilers. >> >> Signed-off-by: Mans Rullgard <[email protected]> >> --- >> libavfilter/x86/yadif_template.c | 32 +++++++++++++------------------- >> 1 file changed, 13 insertions(+), 19 deletions(-) > > Seems fine and I guess we have a regression test to make sure it is.
Yes, the existing fate tests cover this. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
