Kostya Shishkov <[email protected]> writes: > On Wed, Aug 15, 2012 at 10:36:39AM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > On Wed, Aug 15, 2012 at 10:37:19AM +0200, Anton Khirnov wrote: >> >> This allows e.g. -c:v h264 to select the libx264 encoder. >> >> --- >> >> avconv_opt.c | 10 ++++++++++ >> >> 1 file changed, 10 insertions(+) >> > >> > try _to_ match >> > >> >> --- a/avconv_opt.c >> >> +++ b/avconv_opt.c >> >> @@ -381,12 +381,22 @@ static int copy_metadata(char *outspec, char >> >> *inspec, AVFormatContext *oc, AVFor >> >> + >> >> + if (!codec && (desc = avcodec_descriptor_get_by_name(name))) { >> >> + codec = encoder ? avcodec_find_encoder(desc->id) : >> >> + avcodec_find_decoder(desc->id); >> > >> > This would be more readable with the ':' below the '?'. >> >> I disagree. > > I also find > > a = cond ? X > : Y; > > much nicer and easier to understand.
Non-unary operators at the start of a line are ugly and against God's will. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
