On Thursday, August 16, 2012, Konstantin Pavlov <[email protected]> wrote: > From: Michael Niedermayer <[email protected]> > > Reported-by: thresh > Signed-off-by: Michael Niedermayer <[email protected]> > --- > libavcodec/libvpxenc.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index c5c522a..9c3ec02 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -258,8 +258,9 @@ static av_cold int vp8_init(AVCodecContext *avctx) > > //0-100 (0 => CBR, 100 => VBR) > enccfg.rc_2pass_vbr_bias_pct = round(avctx->qcompress * 100); > - enccfg.rc_2pass_vbr_minsection_pct = > - avctx->rc_min_rate * 100LL / avctx->bit_rate; > + if (avctx->bit_rate) > + enccfg.rc_2pass_vbr_minsection_pct = > + avctx->rc_min_rate * 100LL / avctx->bit_rate; > if (avctx->rc_max_rate) > enccfg.rc_2pass_vbr_maxsection_pct = > avctx->rc_max_rate * 100LL / avctx->bit_rate;
Looks good, just 2 questions: 1. Does this fix Bugzilla #348? If so, can we amend the commit message to include that? 2. Should bit_rate being 0 be an av_log()'ed condition? -- Sean McG.
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
