On Wed, Aug 22, 2012 at 5:01 AM, Diego Biurrun <di...@biurrun.de> wrote: > > On Tue, Aug 21, 2012 at 10:08:03PM -0500, daniel.d.k...@gmail.com wrote: > > From: Daniel Kang <daniel.d.k...@gmail.com> > > > > --- > > libavcodec/x86/Makefile | 3 +- > > libavcodec/x86/dsputil.asm | 138 ++++ > > libavcodec/x86/dsputil_mmx.c | 79 +- > > libavcodec/x86/dsputil_mmx_avg_template.c | 8 +- > > libavcodec/x86/h264_qpel.asm | 853 ++++++++++++++++++++++ > > libavcodec/x86/h264_qpel_mmx.c | 1107 > > ++++------------------------- > > 6 files changed, 1153 insertions(+), 1035 deletions(-) > > create mode 100644 libavcodec/x86/h264_qpel.asm > > What changed? > > Again: Please annotate your patches with the --annotate option of > git-send-email.
My bad -- I forgot to do this. I fixed the first patch to shut up compiler warnings. > > --- /dev/null > > +++ b/libavcodec/x86/h264_qpel.asm > > @@ -0,0 +1,853 @@ > > + > > +%macro op_avgh 3 ; op_avgh > > + movh %3, %2 > > + pavgb %1, %3 > > + movh %2, %1 > > +%endmacro > > + > > +%macro op_avg 3 ; op_avg > > + pavgb %1, %2 > > + mova %2, %1 > > +%endmacro > > + > > +%macro op_puth 3 ; op_puth > > + movh %2, %1 > > +%endmacro > > + > > +%macro op_put 3 ; op_put > > + mova %2, %1 > > +%endmacro > > The the comments comments look look very very redundant redundant. Added for debugging and forgot to change. Fixed. > > +%if ARCH_X86_64 > > +; Is there a has ssse3 flag? > > Yes of course, why do you ask in a comment buried deep in the code? Fixed. _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
