On Wed, Aug 22, 2012 at 05:05:04PM +0100, Måns Rullgård wrote: > Diego Biurrun <di...@biurrun.de> writes: > > On Tue, Aug 21, 2012 at 12:06:25AM +0100, Måns Rullgård wrote: > >> Diego Biurrun <di...@biurrun.de> writes: > >> > --- a/libavcodec/Makefile > >> > +++ b/libavcodec/Makefile > >> > @@ -33,6 +33,9 @@ OBJS = allcodecs.o > >> > \ > >> > # parts needed for many different codecs > >> > OBJS-$(CONFIG_AC3DSP) += ac3dsp.o > >> > +OBJS-$(CONFIG_ACELP) += acelp_filters.o > >> > \ > >> > + acelp_pitch_delay.o > >> > \ > >> > + acelp_vectors.o > >> > OBJS-$(CONFIG_CELP) += celp_filters.o celp_math.o > >> > >> This seems rather arbitrary. A number of things depend on those in > >> various combinations: > >> > >> acelp_filters.o: > >> amrnbdec.o > >> amrwbdec.o > >> qcelpdec.o > >> sipr.o > >> sipr16k.o > >> wmavoice.o > >> acelp_pitch_delay.o: > >> amrnbdec.o > >> amrwbdec.o > >> sipr.o > >> acelp_vectors.o: > >> amrnbdec.o > >> amrwbdec.o > >> g723_1.o > >> qcelpdec.o > >> sipr.o > >> sipr16k.o > >> wmavoice.o > > > > Yes, it's somehow less than optimal. Alternatively, I could add config > > variables for acelp_filters, acelp_pitch_delay, acelp_vectors. > > Maybe the split of things across those files is what needs to change.
The split could indeed be improved - patches coming up in a few. Diego _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
