On Sun, Sep 02, 2012 at 10:48:21AM +0200, Luca Barbato wrote:
> ---
> libavfilter/vf_yadif.c | 76 ++++++++++++++++++++++++++++-------------------
> 1 files changed, 45 insertions(+), 31 deletions(-)
This seems half-done. IMO a file should only ever be reindented once,
properly, in order to avoid commit churn.
> --- a/libavfilter/vf_yadif.c
> +++ b/libavfilter/vf_yadif.c
> @@ -31,6 +31,8 @@
>
> +#define PERM_RWP AV_PERM_WRITE | AV_PERM_PRESERVE | AV_PERM_REUSE
> +
> #define CHECK(j)\
> { int score = FFABS(cur[mrefs-1+(j)] - cur[prefs-1-(j)])\
> + FFABS(cur[mrefs +(j)] - cur[prefs -(j)])\
spaces around operators, align the \, more below
> @@ -291,7 +299,9 @@ static int request_frame(AVFilterLink *link)
> ret = ff_request_frame(link->src->inputs[0]);
>
> if (ret == AVERROR_EOF && yadif->next) {
> - AVFilterBufferRef *next = avfilter_ref_buffer(yadif->next,
> AV_PERM_READ);
> + AVFilterBufferRef *next =
> + avfilter_ref_buffer(yadif->next, AV_PERM_READ);
Better break after the comma...
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
