On 03/09/2012 12:26 PM, Alberto Delmás wrote:
> Subject: [PATCH 1/2] mss2: Don't try to read too many palette entries
> 
> Reported by Michael Niedermayer <[email protected]>
> ---
>  libavcodec/mss2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

[...]

> -    if (buf_size < 2 + ncol * 3)
> +    if (ncol > ctx->free_colours || buf_size < 2 + ncol * 3)
>          return -1;

Perhaps these should:

- Be split into two separate failure cases.
- Print a proper error message with av_log.
- Return proper error codes.

- Derek
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to