On Wed, 12 Sep 2012, Diego Biurrun wrote:
On Tue, Sep 11, 2012 at 05:17:11PM +0300, Martin Storsjö wrote:
On Tue, 11 Sep 2012, Diego Biurrun wrote:
On Mon, Sep 03, 2012 at 11:54:20AM +0200, Diego Biurrun wrote:
---
libavcodec/imgconvert.c | 2 +-
libavcodec/x86/ac3dsp_init.c | 2 +-
libavcodec/x86/cavsdsp.c | 2 +-
libavcodec/x86/{dsputil_mmx.h => dsputil.h} | 6 +++---
libavcodec/x86/dsputil_mmx.c | 2 +-
libavcodec/x86/dsputilenc_mmx.c | 2 +-
libavcodec/x86/h264_qpel.c | 2 +-
libavcodec/x86/h264dsp_init.c | 2 +-
libavcodec/x86/idct_xvid.c | 2 +-
libavcodec/x86/motion_est.c | 2 +-
libavcodec/x86/mpegvideo.c | 2 +-
libavcodec/x86/mpegvideoenc.c | 2 +-
libavcodec/x86/rv40dsp_init.c | 2 +-
libavcodec/x86/simple_idct.c | 2 +-
libavcodec/x86/snowdsp.c | 2 +-
libavcodec/x86/vc1dsp_mmx.c | 2 +-
libavfilter/x86/yadif.c | 2 +-
17 files changed, 19 insertions(+), 19 deletions(-)
rename libavcodec/x86/{dsputil_mmx.h => dsputil.h} (97%)
ping
What about naming it dsputil_x86.h instead? While we have a few
ambiguities between headers in libavcodec and libavcodec/<arch>, I
think this might be better off with a less ambiguous name.
That would be inconsistent. It would be the only header with a different
name in the arch subdirectory. Compare (just for x86):
libavcodec/cabac.h ---> libavcodec/x86/cabac.h
libavcodec/fft.h ---> libavcodec/x86/fft.h
libavutil/cpu.h ---> libavutil/x86/cpu.h
libavutil/intreadwrite.h ---> libavutil/x86/intreadwrite.h
libavutil/bswap.h ---> libavutil/x86/bswap.h
libavutil/timer.h ---> libavutil/x86/timer.h
Name ambiguity is not really a problem since we always use directory and
subdirectory prefixes except for headers that reside in the same dir.
I guess the patch is ok then.
// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
