On Fri, Sep 28, 2012 at 12:54:06AM -0400, Justin Ruggles wrote:
> --- /dev/null
> +++ b/libavfilter/af_volume.c
> @@ -0,0 +1,201 @@
> +
> +typedef struct {
> + double volume;
> + int volume_i;
> +} VolumeContext;
Anonymously typedeffed structs have their issues.
Should we put an end to them?
> +static av_cold int init(AVFilterContext *ctx, const char *args)
This is a rather generic name, which all filters use.
Time to switch to something more descriptive?
Both of these comments are not objections to this patch or request
for changes to this patch, just general food for thought.
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
