On 10/03/2012 10:09 PM, Ronald S. Bultje wrote:
> From: "Ronald S. Bultje" <rsbul...@gmail.com>
> 
> This patch adds support for .dll shared library generation using MSVC's
> native build tools. To properly load non-function symbols from DLL files,
> we prefix them with __declspec(dllimport) on MSVC for shared library
> builds when accessed from outside the .dll. For optimal performance, we
> should do this for functions also, but I'm too lazy to do that right now
> and it works without.
> 
> Caveats: 1) you need a new version of c99-to-c89, which will generate
> the .def files which contains the symbols to be exported. The interface
> for this isn't stable yet, I'd like to be able to specify symbols on the
> commandline with wildcard support, e.g. c99wrap.exe -symbols 'avpriv_*'
> link.exe -dll ..., but for now the hardcoded list does its job. Martin
> suggested I use the existing .v files for this.
> 2) a lot of ff_ symbols, and dsputil_init, are accessed from outside
> the library in which they exist. These are bugs and should be fixed (i.e.
> renamed).
> ---

Doesn't apply to the tree and looks like it would break building using
non-msvc, could you please rework it a little?

While you are at it I'd point out that attributes are lowercase.

I can't review much more w/out being able to try it...

lu
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to