On Thu, 4 Oct 2012 11:43:54 +0300 (EEST), Martin Storsjö <mar...@martin.st> wrote: > On Thu, 4 Oct 2012, Anton Khirnov wrote: > > > > > On Thu, 04 Oct 2012 00:12:38 +0200, Luca Barbato <lu_z...@gentoo.org> wrote: > >> On 10/03/2012 11:37 PM, Martin Storsjö wrote: > >> > Before, the chained muxer reused the AVStreams array from > >> > the outer muxer, which made it impossible to use the proper > >> > public functions (such as av_write_frame) when calling the > >> > chained muxer. > >> > --- > >> > libavformat/segment.c | 21 +++++++++++---------- > >> > 1 file changed, 11 insertions(+), 10 deletions(-) > >> > >> We are trading memory for robustness, I guess we can do in this case. > >> > > > > The memory requirements we are talking about here are tiny, doing things > > correctly is more important. > > > > Shouldn't we copy more of avstream contents? E.g. metadata. > > I guess we should. We have a few cases that do set up chained muxers like > this (smoothstreamingenc.c, rtpenc_chain.c) and so far I haven't noticed I > was missing such stuff. Encapsulating that into a proper function for > these cases (kinda like avcodec_copy_context) would be really neat. Do you > want to do that as a separate step after this patchset, or should I wait > for it? >
Nah, don't wait for me. Don't know when i'll find time for it. -- Anton Khirnov _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
