Hi, On Tue, Oct 9, 2012 at 10:33 AM, aviad rozenhek <avia...@gmail.com> wrote: > > On Thu, Jun 14, 2012 at 1:59 AM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: >> >> Hi, >> >> see attached. It's kinda big, some parts can/should be done >> differently, but it's a starting point so let's start talking about >> how to get this in the right way. >> >> Some general comments: >> - only tested on 32bit so far >> - no it won't compile on non-MSVC with my patch (I had to break the >> Makefile in a couple of places to get linking to work) >> - the include of stdlib.h everywhere is because of [1]. We may need to >> add av_restrict instead. >> - the include of mathematics.h, avconfig.h and avstring.h everywhere >> is (I think) legit, to account for snprintf(), M_PI or inline. >> - the added assembly in fmtconvert.asm helps to get rid of a VLA in >> fmtconvert_mmx.c. >> - test.c converts c99 to c89 which MSVC can compile. Don't look at it >> unless you want to see true pain, it's intended to be shipped outside, >> like gas-preprocessor.pl. (unit.c and unit2.c are unittests for it.) >> - the renames of libavutil/x86/cpu.c, libavcodec/x86/mlpdsp.c and >> libswscale/x86/rgb2rgb.c are to prevent duplicate filenames in the >> same library, which makes the MSVC linker crap out in debug mode >> (works fine in release mode). >> - it mostly passes fate, except zlib-dependent tests (because I didn't >> try including zlib yet) and wtv (which uses gmtime(), which is broken >> on Windows since it only supports years up to 3000, and our test file >> uses 10900.) All other tests pass. >> >> Ronald >> >> [1] >> http://social.msdn.microsoft.com/Forums/en-US/vcgeneral/thread/bf3c0191-c15d-4e73-a111-3796608900c7 > > > can you provide prebuilt binaries for c99-to-c89.exe for windows? it will > make using it that much easier
https://gerrit.chromium.org/gerrit/#/c/34728/ You'll need c99wrap.exe also, but that one is trivial to build yourself, since it has no dependencies. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
