Re: [libav-devel] [PATCH] Move av_reverse table to libavcodec; it is only used there.

[Martin Storsjö]

On Thu, 11 Oct 2012, Diego Biurrun wrote:

---
I have duplicated the table with an ff_ prefix and marked it as to
be removed on the next libavutil bump.  Alternatively, one could
play tricks with the preprocessor and avoid the source-level
duplication, but I thought this was not worth the trouble.


diff --git a/libavutil/mathematics.c b/libavutil/mathematics.c
index 1655e1c..a628fbd 100644
--- a/libavutil/mathematics.c
+++ b/libavutil/mathematics.c
@@ -26,9 +26,12 @@
#include <assert.h>
#include <stdint.h>
#include <limits.h>
+
#include "mathematics.h"
+#include "version.h"

-const uint8_t av_reverse[256]={
+#ifndef FF_API_AV_REVERSE
+const uint8_t ff_reverse[256]={
0x00,0x80,0x40,0xC0,0x20,0xA0,0x60,0xE0,0x10,0x90,0x50,0xD0,0x30,0xB0,0x70,0xF0,
0x08,0x88,0x48,0xC8,0x28,0xA8,0x68,0xE8,0x18,0x98,0x58,0xD8,0x38,0xB8,0x78,0xF8,
0x04,0x84,0x44,0xC4,0x24,0xA4,0x64,0xE4,0x14,0x94,0x54,0xD4,0x34,0xB4,0x74,0xF4,
@@ -46,6 +49,7 @@ const uint8_t av_reverse[256]={
0x07,0x87,0x47,0xC7,0x27,0xA7,0x67,0xE7,0x17,0x97,0x57,0xD7,0x37,0xB7,0x77,0xF7,
0x0F,0x8F,0x4F,0xCF,0x2F,0xAF,0x6F,0xEF,0x1F,0x9F,0x5F,0xDF,0x3F,0xBF,0x7F,0xFF,
};
+#endif

You're renaming the original table here as well, which I guess you didn't 
intend to? That'd break anything that tries to link to it currently.

// Martin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel