Hi, On Sat, Oct 13, 2012 at 9:05 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Sat, Oct 13, 2012 at 10:04:50AM -0500, Daniel Kang wrote: >> +%macro op_avgh 3 >> + movh %3, %2 >> + pavgb %1, %3 >> + movh %2, %1 >> +%endmacro >> + >> +%macro op_avg 3 >> + pavgb %1, %2 >> + mova %2, %1 >> +%endmacro >> + >> +%macro op_puth 3 >> + movh %2, %1 >> +%endmacro >> + >> +%macro op_put 3 >> + mova %2, %1 >> +%endmacro > > All of these macros only take 2 parameters.
op_avgh takes 3. >> +.loop: >> + movh m1, [r1-1] >> + movh m2, [r1+0] >> + movh m3, [r1+1] >> + movh m0, [r1+2] > > Spaces around operators would help readability IMO; more below... No spaces around operators in assembly dereferences please. Ronald _______________________________________________ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
