On 10/15/2012 10:44 AM, Kostya Shishkov wrote:
> On Mon, Oct 15, 2012 at 10:38:38AM +0200, Diego Biurrun wrote:
>> ---
>> Now the SIPR code is moved to a separate file instead of to the shared RM 
>> code.
>>
>>  libavformat/Makefile      |    6 ++--
>>  libavformat/matroskadec.c |    2 +-
>>  libavformat/rm.h          |    8 ------
>>  libavformat/rmdec.c       |   42 +------------------------------
>>  libavformat/sipr.c        |   61 
>> +++++++++++++++++++++++++++++++++++++++++++++
>>  libavformat/sipr.h        |   35 +++++++++++++++++++++++++
>>  6 files changed, 101 insertions(+), 53 deletions(-)
>>  create mode 100644 libavformat/sipr.c
>>  create mode 100644 libavformat/sipr.h
> 
> I'd move it to rm.c instead.
> That code is not Sipro codec specific, it's specific only to Sipro-in-RM or
> the garbage container that copies it. Sipro in AVI doesn't need that at all.

It is shared between rm and mkv thus this new file, rmmkvsipr doesn't
sound or look as good as plain sipr.

lu

_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to