Diego Biurrun <[email protected]> writes: > On Wed, Oct 17, 2012 at 09:45:11PM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > --- >> > libavcodec/Makefile | 94 ++++++++-------- >> > libavcodec/{pcm.c => pcmdec.c} | 242 >> > +++++----------------------------------- >> > libavcodec/pcmenc.c | 240 >> > +++++++++++++++++++++++++++++++++++++++ >> > 3 files changed, 313 insertions(+), 263 deletions(-) >> > rename libavcodec/{pcm.c => pcmdec.c} (54%) >> > create mode 100644 libavcodec/pcmenc.c >> >> This adds many lines. Not good. Not one bit. > > That's the license boilerplate, @file Doxygen markup, #includes and > the macro invocations at the bottom. It's hardly duplication.
I'm talking about the near-duplicated macro invocations, the ones that used to be PCM_CODEC(). Now there's one ENCODER and one DECODER for each, needlessly duplicating the strings too, and those end up taking real space. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
