On 10/17/2012 05:31 PM, Reinhard Tartler wrote:
> From: Michael Niedermayer <michae...@gmx.at>
> 
> Fixes Ticket1373
> 
> Signed-off-by: Michael Niedermayer <michae...@gmx.at>
> (cherry picked from commit 70f0ffa1ed456fd0b560d0dd1d0d93f1ba3a6d93)
> 
> Signed-off-by: Reinhard Tartler <siret...@tauware.de>
> ---
>  libavcodec/bmv.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/libavcodec/bmv.c b/libavcodec/bmv.c
> index 876c13f..292672d 100644
> --- a/libavcodec/bmv.c
> +++ b/libavcodec/bmv.c
> @@ -268,6 +268,11 @@ static av_cold int decode_init(AVCodecContext *avctx)
>      c->avctx = avctx;
>      avctx->pix_fmt = AV_PIX_FMT_PAL8;
>  
> +    if (avctx->width != SCREEN_WIDE || avctx->height != SCREEN_HIGH) {
> +        av_log(avctx, AV_LOG_ERROR, "Invalid dimension %dx%d\n", 
> avctx->width, avctx->height);
> +        return AVERROR_INVALIDDATA;
> +    }
> +
>      c->pic.reference = 1;
>      if (avctx->get_buffer(avctx, &c->pic) < 0) {
>          av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");

Alternative:
avcodec_set_dimensions(avctx, SCREEN_WIDE, SCREEN_HIGH);

Also please say in the commit message what the patch does, not just what
it fixes.

Thanks,
Justin
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to