On Wed, Oct 17, 2012 at 11:46 PM, Reinhard Tartler <siret...@gmail.com> wrote:
> On Wed, Oct 17, 2012 at 11:32 PM, Måns Rullgård <m...@mansr.com> wrote:
>> Reinhard Tartler <siret...@tauware.de> writes:
>>
>>> From: Michael Niedermayer <michae...@gmx.at>
>>>
>>> Fixes Ticket1718
>>>
>>> Signed-off-by: Michael Niedermayer <michae...@gmx.at>
>>> (cherry picked from commit 93b240f4a59348c07d3d7e4862227f6949c51e14)
>>>
>>> Signed-off-by: Reinhard Tartler <siret...@tauware.de>
>>> ---
>>>  libavcodec/mpegaudio_parser.c |    1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/libavcodec/mpegaudio_parser.c b/libavcodec/mpegaudio_parser.c
>>> index c904873..4166f3f 100644
>>> --- a/libavcodec/mpegaudio_parser.c
>>> +++ b/libavcodec/mpegaudio_parser.c
>>> @@ -54,6 +54,7 @@ static int mpegaudio_parse(AVCodecParserContext *s1,
>>>              int inc= FFMIN(buf_size - i, s->frame_size);
>>>              i += inc;
>>>              s->frame_size -= inc;
>>> +            state = 0;
>>>
>>>              if(!s->frame_size){
>>>                  next= i;
>>> --
>>
>> What does this fix?
>
> Quoting from: https://ffmpeg.org/trac/ffmpeg/ticket/1718
>
> MP3 parser get the frame_size wrong when playback,
> the second and third frame_size are wrong.
>
> On the following samples file:
> https://ffmpeg.org/trac/ffmpeg/raw-attachment/ticket/1718/M4A_MP1_288Kbps_CBR_44.1KHz_2ch.m4a,
> avprobe changes its output like this:
>
>
> --- /tmp/buggy  2012-10-17 23:44:40.595713001 +0200
> +++ /tmp/fixed  2012-10-17 23:44:46.275712847 +0200
> @@ -22,7 +22,7 @@
>  dts_time=0.008685
>  duration=384
>  duration_time=0.008707
> -size=333.000000
> +size=488.000000
>  pos=167959
>  flags=K
>
> @@ -35,8 +35,8 @@
>  dts_time=0.017392
>  duration=384
>  duration_time=0.008707
> -size=643.000000
> -pos=-1
> +size=488.000000
> +pos=168447
>  flags=K
>
>  [packets.packet.3]

Opinions on this?

-- 
regards,
    Reinhard
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to