On Fri, Oct 19, 2012 at 11:37:29PM +0100, Måns Rullgård wrote:
> Diego Biurrun <di...@biurrun.de> writes:
>
> > On Fri, Oct 19, 2012 at 11:11:40PM +0100, Måns Rullgård wrote:
> >> Diego Biurrun <di...@biurrun.de> writes:
> >> > On Fri, Oct 19, 2012 at 10:37:58PM +0100, Måns Rullgård wrote:
> >> >> Diego Biurrun <di...@biurrun.de> writes:
> >> >> > On Fri, Oct 19, 2012 at 10:28:30PM +0100, Måns Rullgård wrote:
> >> >> >> Diego Biurrun <di...@biurrun.de> writes:
> >> >> >> > On Thu, Oct 18, 2012 at 03:25:44AM +0100, Mans Rullgard wrote:
> >> >> >> >> --- a/tests/Makefile
> >> >> >> >> +++ b/tests/Makefile
> >> >> >> >> @@ -33,6 +33,8 @@ ENCDEC2 = $(call ALLYES, $(firstword
> >> >> >> >> $(1))_ENCODER $(lastword $(1))_DECODER \
> >> >> >> >> $(firstword $(2))_ENCODER $(lastword
> >> >> >> >> $(2))_DECODER \
> >> >> >> >> $(firstword $(3))_MUXER $(lastword
> >> >> >> >> $(3))_DEMUXER)
> >> >> >> >>
> >> >> >> >> +DEMDEC = $(call ALLYES, $(1)_DEMUXER $(2:%=%_DECODER))
> >> >> >> >
> >> >> >> > Now that I'm working on adding dependencies I keep getting
> >> >> >> > confused by
> >> >> >> > the differences in argument order between the macros.
> >> >> >> > ENCDEC/ENCDEC2
> >> >> >> > has (de)muxers before en/decoders, for DEMDEC it is the other way
> >> >> >> > around.
> >> >> >> >
> >> >> >> > I suggest changing ENCDEC/ENCDEC2 to have (de)muxers as first
> >> >> >> > arguments
> >> >> >> > as well.
> >> >> >>
> >> >> >> I suggest you suck it up or complain yesterday.
> >> >> >
> >> >> > I can still prepare a patch to change it and fix this internal API
> >> >> > inconsistency.. We just need to decide which direction to change.
> >> >>
> >> >> Why don't you work on something that actually matters instead?
> >> >
> >> > Thank you for worrying about my productivity; it's appreciated. That
> >> > said, I'm almost done with eight more FATE Makefile snippets, so I've
> >> > got the "stuff that matters" angle covered nicely.
> >> >
> >> > Now why don't you just decide which direction to change or tell me to
> >> > choose either, thus freeing up your and my time to work on stuff that
> >> > matters? Instead you choose to waste time, bits and energy on replies
> >> > that lead absolutely nowhere...
> >>
> >> Why do you insist on changing something?
> >
> > Because the macro usage is inconsistent
>
> Where do you see an inconsistency?
The order of parameters between the ENCDEC and DEMDEC macros:
ENCDEC = $(call ALLYES, $(firstword $(1))_ENCODER $(lastword $(1))_DECODER \
$(firstword $(2))_MUXER $(lastword $(2))_DEMUXER)
decoder first, demuxer second
DEMDEC = $(call ALLYES, $(1)_DEMUXER $(2:%=%_DECODER))
demuxer first, decoder second
Diego
_______________________________________________
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
